[FEATURE] Added dispute_assertion() to Dispute Module#66
Conversation
aandrewchung
requested review from
DracoLi,
bpolania,
edisonz0718 and
sebsadface
as code owners
| else: | ||
| function_name_counts[item['name']] = 1 | ||
|
|
||
| # Process inputs, replacing 'from' with 'from_address' |
There was a problem hiding this comment.
"from" is a reserved keyword in python
| """ | ||
| try: | ||
| # Validate IP ID | ||
| # ip_id = self._validate_address(ip_id) |
There was a problem hiding this comment.
should this be uncommented?
| ip_account = IPAccountImplClient(self.web3, contract_address=ip_id) | ||
|
|
||
| # Get assertion details to determine bond amount | ||
| bond = get_assertion_details(self.web3, self.arbitration_policy_uma_client, assertion_id) |
There was a problem hiding this comment.
can we add a check here to ensure the wallet has enough wip? if not, we can throw a more detailed error msg, to hint that the wip client should be used to convert ip -> wip, and also indicate the bond required.
| ip_account = IPAccountImplClient(self.web3, contract_address=ip_id) | ||
|
|
||
| # Get assertion details to determine bond amount | ||
| bond = get_assertion_details(self.web3, self.arbitration_policy_uma_client, assertion_id) |
There was a problem hiding this comment.
I think need a helper method to get the bond amount for an assertion_id in this client. otherwise, no way for users to know how much bond is needed.
…rtion() and added get_bond_amount()
DracoLi
left a comment
DracoLi
left a comment
There was a problem hiding this comment.
Looks good, one non-blocking suggestion
| """ | ||
| return arbitration_policy_uma_client.oov3() | ||
|
|
||
| def get_assertion_details(web3: Web3, arbitration_policy_uma_client: ArbitrationPolicyUMAClient, assertion_id: str) -> int: |
There was a problem hiding this comment.
i think this can just be get_assertion_bond for clarity.
3 participants
Description
Test Plan
Related Issue
n/a
Notes